Avoid iOS Safari pointer capture exceptions on new sketch canvas#1
Open
Avoid iOS Safari pointer capture exceptions on new sketch canvas#1
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
getReader()+await reader.read()loops rather thanfor await...of, so async-iteration-on-streams is not the cause.setPointerCapture/releasePointerCapturecalls on the new-sketch canvas which can throw on some iOS Safari touch pointers and break input handling.Description
safelySetPointerCaptureandsafelyReleasePointerCapturehelpers that feature-detect and wrapsetPointerCapture/releasePointerCaptureintry/catchto avoid exceptions.e.currentTarget.setPointerCapture(e.pointerId)ande.currentTarget.releasePointerCapture(e.pointerId)calls with the safe wrappers insrc/app/new/page.tsx.ReadableStream.getReader()+reader.read()loops which are Safari-compatible.Testing
pnpm -s eslint src/app/new/page.tsxwhich passed.pnpm -s tsc --noEmitwhich passed.Codex Task